fix: inline convert test Dockerfile data#762
Closed
raharper wants to merge 2 commits intoproject-stacker:mainfrom
Closed
fix: inline convert test Dockerfile data#762raharper wants to merge 2 commits intoproject-stacker:mainfrom
raharper wants to merge 2 commits intoproject-stacker:mainfrom
Conversation
Skip downloading Dockerfiles for the convert test as they add instability to the tests when github is unreliable. Capture what we are fetching and the sha256sum values. Signed-off-by: Ryan Harper <rharper@woxford.com>
raharper
requested review from
hallyn,
mikemccracken,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
Signed-off-by: Ryan Harper <rharper@gmail.com>
Contributor
Author
|
Looking inside the dockerfiles, this won't help since they fetch the same resources from github; they already have lots of retries... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip downloading Dockerfiles for the convert test as they add instability to the tests when github is unreliable. Capture what we are fetching and the sha256sum values.
What type of PR is this?
bug
Which issue does this PR fix:
Help removing instability in the convert test case
What does this PR do / Why do we need it:
We had a recent nightly CI failure due to github repo instability so instead of downloading (git clone, etc) capture the content in our repository.
If an issue # is not available please add repro steps and logs showing the issue:
https://github.com/project-stacker/stacker/actions/runs/23416513187/job/68112948797
Testing done on this change:
CI
Automation added to e2e:
None
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.